How to avoid memory leak with shared_ptr?

If you have circular references like this, one object should hold a weak_ptr to the other, not a shared_ptr.

From the shared_ptr introduction:

Because the implementation uses reference counting, cycles of shared_ptr instances will not be reclaimed. For example, if main() holds a shared_ptr to A, which directly or indirectly holds a shared_ptr back to A, A‘s use count will be 2. Destruction of the original shared_ptr will leave A dangling with a use count of 1. Use weak_ptr to “break cycles.”

Thanks, Glen, for the link.

Leave a Comment