do I need to close a std::fstream? [duplicate]

I think the previous answers are misleading.

fstream is a proper RAII object, it does close automatically at the end of the scope, and there is absolutely no need whatsoever to call close manually when closing at the end of the scope is sufficient.

In particular, it’s not a “best practice” and it’s not necessary to flush the output.

And while Drakosha is right that calling close gives you the possibility to check the fail bit of the stream, nobody does that, anyway.

In an ideal world, one would simply call stream.exceptions(ios::failbit) beforehand and handle the exception that is thrown in an fstream’s destructor. But unfortunately exceptions in destructors are a broken concept in C++ so that’s not a good idea.

So if you want to check the success of closing a file, do it manually (but only then).

Related Contents:

  1. How to truncate a file while it is open with fstream
  2. How to write to middle of a file in C++?
  3. Why is "using namespace std;" considered bad practice?
  4. Read file line by line using ifstream in C++
  5. What’s the difference between “STL” and “C++ Standard Library”?
  6. Reading from text file until EOF repeats last line [duplicate]
  7. Can you remove elements from a std::list while iterating through it?
  8. How to construct a c++ fstream from a POSIX file descriptor?
  9. mmap() vs. reading blocks
  10. What is the performance overhead of std::function?
  11. Converting std::__cxx11::string to std::string
  12. Sorting zipped (locked) containers in C++ using boost or the STL
  13. printf with std::string?
  14. Sorting std::map using value
  15. A std::map that keep track of the order of insertion?
  16. Deleting elements from std::set while iterating
  17. Flattening iterator
  18. How is std::string implemented?
  19. How do I Search/Find and Replace in a standard string?
  20. Why is the destructor of a future returned from `std::async` blocking?
  21. Should I use std::function or a function pointer in C++?
  22. Append an int to a std::string [duplicate]
  23. Overload resolution failure when streaming object via implicit conversion to string
  24. In C++ is there a way to go to a specific line in a text file?
  25. declaring a priority_queue in c++ with a custom comparator
  26. std::shared_ptr thread safety
  27. What can and can’t I specialize in the std namespace?
  28. How can I use Standard Library (STL) classes in my dll interface or ABI?
  29. How to get error message when ifstream open fails
  30. Why would I ever use push_back instead of emplace_back?
  31. How to use std::async on a member function?
  32. How do I erase elements from STL containers?
  33. C++ Filehandling: Difference between ios::app and ios::ate?
  34. Will specialization of function templates in std for program-defined types no longer be allowed in C++20?
  35. Reading and writing to the same file using the same fstream
  36. std::pair of references
  37. Retrieving file descriptor from a std::fstream [duplicate]
  38. Passing rvalues through std::bind
  39. std::bind overload resolution
  40. Can std::begin work with array parameters and if so, how?
  41. What is the fastest way to change a key of an element inside std::map
  42. Forward Declaration of variables/classes in std namespace
  43. Why am I getting string does not name a type Error?
  44. What is the difference between using a struct with two fields and a pair?
  45. Why is failbit set when eof is found on read?
  46. Why does std::vector work with incomplete types in class definitions?
  47. C++ When is it OK to extend the `std` namespace?
  48. cc1plus: error: unrecognized command line option “-std=c++11” with g++
  49. std::lexical_cast – is there such a thing?
  50. How to reset std::cin when using it?

Leave a Comment